i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi bus manager: casts path_id to uint8.

Browse Source 
* added a TODO about create_id() generating int32 ids when we need uint8.
* GCC 4.7 warning fixed: narrowing conversion.
This commit is contained in:
Jérôme Duval
2013-04-26 21:17:36 +02:00
parent 848acd672c
commit 44d2f5f53e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/scsi/sim_interface.cpp
+3 -2
View File
@@ -27,7 +27,7 @@ static status_t
scsi_controller_added(device_node *parent) scsi_controller_added(device_node *parent)
{ {
const char *controller_name; const char *controller_name;
int pathID; int32 pathID;
SHOW_FLOW0(4, ""); SHOW_FLOW0(4, "");
@@ -48,7 +48,8 @@ scsi_controller_added(device_node *parent)
device_attr attrs[] = { device_attr attrs[] = {
// remember who we are // remember who we are
// (could use the controller name, but probably some software would choke) // (could use the controller name, but probably some software would choke)
{ SCSI_BUS_PATH_ID_ITEM, B_UINT8_TYPE, { ui8: pathID }}, // TODO create_id() generates a 32 bit ranged integer but we need only 8 bits
{ SCSI_BUS_PATH_ID_ITEM, B_UINT8_TYPE, { ui8: (uint8)pathID }},
// tell PnP manager to clean up ID // tell PnP manager to clean up ID
// { PNP_MANAGER_ID_GENERATOR, B_STRING_TYPE, { string: SCSI_PATHID_GENERATOR }}, // { PNP_MANAGER_ID_GENERATOR, B_STRING_TYPE, { string: SCSI_PATHID_GENERATOR }},