From 44e4aca7cc956b1bf99f6f9caa4e85c453d647d7 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Wed, 16 Dec 2020 06:18:46 +0900 Subject: [PATCH] compat/freebsd_network: Fix dead store Fix value stored to 'newPowerManagementStatus' is never read. Pointed out by Clang Static Analyzer. It seems FreeBSD's pci_set_powerstate_method() writes 'status' (newPowerManagementStatus in Haiku) with PCI_WRITE_CONFIG (pci_write_config in Haiku). Change-Id: I9b11f746ed8e772a3f839e1bd5a6b432c9e8ff6b Reviewed-on: https://review.haiku-os.org/c/haiku/+/3513 Reviewed-by: waddlesplash --- src/libs/compat/freebsd_network/bus.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/compat/freebsd_network/bus.cpp b/src/libs/compat/freebsd_network/bus.cpp index baa495cf46..6b20ac644d 100644 --- a/src/libs/compat/freebsd_network/bus.cpp +++ b/src/libs/compat/freebsd_network/bus.cpp @@ -1002,8 +1002,8 @@ pci_set_powerstate(device_t dev, int newPowerState) } TRACE_PCI(dev, "%s: D%i -> D%i\n", __func__, oldPowerState, newPowerState); - pci_write_config(dev, capabilityRegister + PCIR_POWER_STATUS, newPowerState, - 2); + pci_write_config(dev, capabilityRegister + PCIR_POWER_STATUS, + newPowerManagementStatus, 2); if (stateTransitionDelayInUs != 0) snooze(stateTransitionDelayInUs);