i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PVS V781: size used before it's checked

Browse Source 
memcpy with a negative parameter doesn't look like a great idea.

Change-Id: I3d1a8c224bd288784f068086652a84b2b75fcea8
Reviewed-on: https://review.haiku-os.org/c/1671
Reviewed-by: waddlesplash <[email protected]>
This commit is contained in:
Adrien Destugues
2019-08-03 00:40:22 +00:00
committed by waddlesplash
parent 5e7114c1e4
commit 4534d86d21
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/btrfs/Inode.cpp
+1 -3
View File
@@ -300,13 +300,11 @@ Inode::ReadAt(off_t pos, uint8* buffer, size_t* _length)
do { do {
ssize_t bytesRead = min_c(sizeof(in), inline_size - offset); ssize_t bytesRead = min_c(sizeof(in), inline_size - offset);
memcpy(in, extent_data->inline_data + offset, bytesRead);
if (bytesRead != (ssize_t)sizeof(in)) {
if (bytesRead <= 0) { if (bytesRead <= 0) {
status = Z_STREAM_ERROR; status = Z_STREAM_ERROR;
break; break;
} }
} memcpy(in, extent_data->inline_data + offset, bytesRead);
zStream.avail_in = bytesRead; zStream.avail_in = bytesRead;
zStream.next_in = (Bytef*)in; zStream.next_in = (Bytef*)in;