From 45f3d65457698b4ec3321d94a9b82056bc4700ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?M=C3=A1ximo=20Casta=C3=B1eda?= <antiswen@yahoo.es>
Date: Tue, 1 Jul 2025 19:51:12 +0200
Subject: [PATCH] Storage Kit: do what the method says in
 `InstalledTypes::_AddSupertype`

That is, just add the supertype if it does not exist. Leave getting it
to the callers that need it.

Fixes: #19653
Change-Id: I79d804161d28684e16a0d84ec3a2fb6788c0b506
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9436
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
---
 headers/private/storage/mime/InstalledTypes.h |  3 +--
 src/kits/storage/mime/InstalledTypes.cpp      | 17 ++++++-----------
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/headers/private/storage/mime/InstalledTypes.h b/headers/private/storage/mime/InstalledTypes.h
index fff75e61d8..27df1a115b 100644
--- a/headers/private/storage/mime/InstalledTypes.h
+++ b/headers/private/storage/mime/InstalledTypes.h
@@ -42,8 +42,7 @@ class InstalledTypes {
 		status_t RemoveType(const char *type);
 
 	private:
-		status_t _AddSupertype(const char *super,
-					std::map<std::string, Supertype>::iterator &i);
+		status_t _AddSupertype(const char* super);
 		status_t _AddSubtype(const char *super, const char *sub);		
 		status_t _AddSubtype(Supertype &super, const char *sub);
 
diff --git a/src/kits/storage/mime/InstalledTypes.cpp b/src/kits/storage/mime/InstalledTypes.cpp
index 81cf03c2c2..7c7c22cb2d 100644
--- a/src/kits/storage/mime/InstalledTypes.cpp
+++ b/src/kits/storage/mime/InstalledTypes.cpp
@@ -173,8 +173,7 @@ InstalledTypes::AddType(const char *type)
 	}
 	if (i == len) {
 		// Supertype only
-		std::map<std::string, Supertype>::iterator i;
-		return _AddSupertype(type, i);
+		return _AddSupertype(type);
 	}
 
 	// Copy the supertype
@@ -235,16 +234,14 @@ InstalledTypes::RemoveType(const char *type)
 	- "error code": failure
 */
 status_t
-InstalledTypes::_AddSupertype(const char *super,
-	std::map<std::string, Supertype>::iterator &i)
+InstalledTypes::_AddSupertype(const char* super)
 {
 	if (super == NULL)
 		return B_BAD_VALUE;
 
 	status_t err = B_OK;
 
-	i = fSupertypes.find(super);
-	if (i == fSupertypes.end()) {
+	if (fSupertypes.find(super) == fSupertypes.end()) {
 		Supertype &supertype = fSupertypes[super];
 		supertype.SetName(super);
 		if (fCachedMessage)
@@ -274,10 +271,9 @@ InstalledTypes::_AddSubtype(const char *super, const char *sub)
 	if (super == NULL || sub == NULL)
 		return B_BAD_VALUE;
 
-	std::map<std::string, Supertype>::iterator i;
-	status_t err = _AddSupertype(super, i);
+	status_t err = _AddSupertype(super);
 	if (!err)
-		err = _AddSubtype(i->second, sub);
+		err = _AddSubtype(fSupertypes[super], sub);
 
 	return err;
 }
@@ -408,8 +404,7 @@ InstalledTypes::_BuildInstalledTypesList()
 					BPrivate::Storage::to_lower(supertype);
 
 					// Add this supertype
-					std::map<std::string, Supertype>::iterator i;
-					if (_AddSupertype(supertype, i) != B_OK)
+					if (_AddSupertype(supertype) != B_OK)
 						DBG(OUT("Mime::InstalledTypes::BuildInstalledTypesList()"
 							" -- Error adding supertype '%s': 0x%" B_PRIx32 "\n",
 							supertype, err));