From 4755a0794e5a640c98b51256e8580a37d4b83190 Mon Sep 17 00:00:00 2001 From: Siarzhuk Zharski Date: Fri, 5 Apr 2013 16:34:47 +0200 Subject: [PATCH] Fix CID992335,CID992334: Check FindRef/String returns Satisfy Coverity by checking return values of FindRef and FindString calls for fSavedMessage. Resolves CID992335 and CID992334. --- src/apps/stylededit/StyledEditWindow.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/apps/stylededit/StyledEditWindow.cpp b/src/apps/stylededit/StyledEditWindow.cpp index 0ca1ab15d6..fac265180b 100644 --- a/src/apps/stylededit/StyledEditWindow.cpp +++ b/src/apps/stylededit/StyledEditWindow.cpp @@ -1469,12 +1469,11 @@ StyledEditWindow::_ReloadDocument(BMessage* message) entry_ref ref; const char* name; - if (fSaveMessage == NULL || message == NULL) + if (fSaveMessage == NULL || message == NULL + || fSaveMessage->FindRef("directory", &ref) != B_OK + || fSaveMessage->FindString("name", &name) != B_OK) return; - fSaveMessage->FindRef("directory", &ref); - fSaveMessage->FindString("name", &name); - BDirectory dir(&ref); status_t status = dir.InitCheck(); BEntry entry;