From 4a1d8b1afb2eec57b14db90ac558912a9ebfdad4 Mon Sep 17 00:00:00 2001
From: Adrien Destugues <pulkomandy@pulkomandy.tk>
Date: Tue, 16 Jul 2019 21:01:53 +0200
Subject: [PATCH] PVS V575: strange values passed to well known functions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: Id6008d93777f860d0b341bcd012fe6f86c99cf35
Reviewed-on: https://review.haiku-os.org/c/1610
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
---
 src/bin/setmime.cpp                             | 2 +-
 src/kits/package/hpkg/PackageFileHeapWriter.cpp | 2 +-
 src/system/libroot/os/driver_settings.cpp       | 2 --
 src/tools/fs_shell/driver_settings.cpp          | 2 --
 4 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/bin/setmime.cpp b/src/bin/setmime.cpp
index 8078c6099e..113973117f 100644
--- a/src/bin/setmime.cpp
+++ b/src/bin/setmime.cpp
@@ -723,8 +723,8 @@ MimeType::_PurgeProperties()
 	delete fBigIcon;
 	fBigIcon = NULL;
 
-	fVectorIcon = NULL;
 	free(fVectorIcon);
+	fVectorIcon = NULL;
 
 	fExtensions.clear();
 	fAttributes.clear();
diff --git a/src/kits/package/hpkg/PackageFileHeapWriter.cpp b/src/kits/package/hpkg/PackageFileHeapWriter.cpp
index 17a7e94514..7d1f7acf3f 100644
--- a/src/kits/package/hpkg/PackageFileHeapWriter.cpp
+++ b/src/kits/package/hpkg/PackageFileHeapWriter.cpp
@@ -162,7 +162,7 @@ private:
 			return fUnusedBuffers.RemoveItem(fUnusedBuffers.CountItems() - 1);
 
 		void* buffer = malloc(fBufferSize);
-		if (buffer == NULL && !fBuffers.AddItem(buffer)) {
+		if (buffer == NULL || !fBuffers.AddItem(buffer)) {
 			free(buffer);
 			throw std::bad_alloc();
 		}
diff --git a/src/system/libroot/os/driver_settings.cpp b/src/system/libroot/os/driver_settings.cpp
index 9004095dac..212a2ecff5 100644
--- a/src/system/libroot/os/driver_settings.cpp
+++ b/src/system/libroot/os/driver_settings.cpp
@@ -457,8 +457,6 @@ load_driver_settings_from_file(int file, const char *driverName)
 				// everything went fine!
 				return handle;
 			}
-
-			free(handle);
 		}
 		// "text" might be NULL here, but that's allowed
 		free(text);
diff --git a/src/tools/fs_shell/driver_settings.cpp b/src/tools/fs_shell/driver_settings.cpp
index 01547f7560..6084ff9eaf 100644
--- a/src/tools/fs_shell/driver_settings.cpp
+++ b/src/tools/fs_shell/driver_settings.cpp
@@ -423,8 +423,6 @@ load_driver_settings_from_file(int file, const char *driverName)
 				// everything went fine!
 				return handle;
 			}
-
-			free(handle);
 		}
 		// "text" might be NULL here, but that's allowed
 		free(text);