From 4a89dc95cb40586a64d621a12b428c83416e2956 Mon Sep 17 00:00:00 2001 From: Alexandre Deckner Date: Tue, 2 Sep 2008 11:02:29 +0000 Subject: [PATCH] - Don't leak the message given to BMessageRunner, thanks stippi! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27285 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/apps/deskbar/TimeView.cpp | 6 +++--- src/apps/pairs/PairsWindow.cpp | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/apps/deskbar/TimeView.cpp b/src/apps/deskbar/TimeView.cpp index 7e1839a95b..bdde5e0f8c 100644 --- a/src/apps/deskbar/TimeView.cpp +++ b/src/apps/deskbar/TimeView.cpp @@ -376,8 +376,8 @@ TTimeView::MouseDown(BPoint point) ShowClockOptions(ConvertToScreen(point)); return; } else if (buttons == B_PRIMARY_MOUSE_BUTTON) { - BMessage * longClickMessage = new BMessage(kMsgLongClick); - longClickMessage->AddPoint("where", point); + BMessage longClickMessage(kMsgLongClick); + longClickMessage.AddPoint("where", point); bigtime_t longClickThreshold; get_click_speed(&longClickThreshold); @@ -385,7 +385,7 @@ TTimeView::MouseDown(BPoint point) delete fLongClickMessageRunner; fLongClickMessageRunner = new BMessageRunner(BMessenger(this), - longClickMessage, longClickThreshold, 1); + &longClickMessage, longClickThreshold, 1); } // flip to/from showing date or time diff --git a/src/apps/pairs/PairsWindow.cpp b/src/apps/pairs/PairsWindow.cpp index 89cf596ba8..b0b87b402e 100644 --- a/src/apps/pairs/PairsWindow.cpp +++ b/src/apps/pairs/PairsWindow.cpp @@ -79,8 +79,9 @@ PairsWindow::MessageReceived(BMessage* message) // message of message runner might not have arrived // yet, so it is deleted here to prevent any leaking // just in case + BMessage message(kMsgPairComparing); fPairComparing = new BMessageRunner(BMessenger(this), - new BMessage(kMsgPairComparing), 5 * 100000L, 1); + &message, 5 * 100000L, 1); fIsPairsActive = false; }