Streaming: Use const reference in place of copying

* Thanks to Markus for reporting.
This commit is contained in:
Dario Casalinuovo
2016-06-25 01:13:10 +02:00
parent 7f28cdba0c
commit 4dd09daff7
9 changed files with 18 additions and 16 deletions
+7 -5
View File
@@ -72,8 +72,8 @@ public:
// Additional constructors used to stream data from protocols
// supported by the Streamer API
BMediaFile(BUrl url);
BMediaFile(BUrl url, int32 flags);
BMediaFile(const BUrl& url);
BMediaFile(const BUrl& url, int32 flags);
// Read-Write streaming constructor
BMediaFile(BUrl destination,
const media_file_format* mfi,
@@ -84,7 +84,7 @@ public:
status_t SetTo(const entry_ref* ref);
status_t SetTo(BDataIO* destination);
// The streaming equivalent of SetTo
status_t SetTo(BUrl url);
status_t SetTo(const BUrl& url);
status_t InitCheck() const;
@@ -179,9 +179,11 @@ private:
void _Init();
void _UnInit();
void _InitReader(BDataIO* source, BUrl* url = NULL,
void _InitReader(BDataIO* source,
const BUrl* url = NULL,
int32 flags = 0);
void _InitWriter(BDataIO* target, BUrl* url,
void _InitWriter(BDataIO* target,
const BUrl* url,
const media_file_format* fileFormat,
int32 flags);
+1 -1
View File
@@ -40,7 +40,7 @@ struct stream_info {
class MediaExtractor {
public:
MediaExtractor(BDataIO* source, int32 flags);
MediaExtractor(BUrl url, int32 flags);
MediaExtractor(const BUrl& url, int32 flags);
~MediaExtractor();
+1 -1
View File
@@ -18,7 +18,7 @@ public:
Streamer();
virtual ~Streamer();
virtual status_t Sniff(BUrl url, BDataIO** source) = 0;
virtual status_t Sniff(const BUrl& url, BDataIO** source) = 0;
private:
virtual void _ReservedStreamer1();
virtual void _ReservedStreamer2();