From 4dff02682c49ce3c55d8c9d8c96f92a84a526ad2 Mon Sep 17 00:00:00 2001 From: Alexander von Gluck IV Date: Mon, 24 Jun 2013 16:29:04 -0500 Subject: [PATCH] Revert "debuganalyzer: Fix double free. CID 992566" This reverts commit ea27e95f489fbb29cedad74788ee607b331f8a2f. * AnEvilYak pointed out that this was a false positive as BObjectList can optionally delete on remove. * I'll add a penny to the bitcoin bad commit jar :) --- src/apps/debuganalyzer/gui/table/Table.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/apps/debuganalyzer/gui/table/Table.cpp b/src/apps/debuganalyzer/gui/table/Table.cpp index 2b2b9bcf8a..2eb7b93cc3 100644 --- a/src/apps/debuganalyzer/gui/table/Table.cpp +++ b/src/apps/debuganalyzer/gui/table/Table.cpp @@ -640,8 +640,10 @@ Table::TableRowsRemoved(TableModel* model, int32 rowIndex, int32 count) } for (int32 i = rowIndex + count - 1; i >= rowIndex; i--) { - if (BRow* row = fRows.RemoveItemAt(i)) + if (BRow* row = fRows.RemoveItemAt(i)) { RemoveRow(row); + delete row; + } } // re-index the subsequent rows