From 4e9bf24dd5c0e3f434f762c21b8368c9048d7ac8 Mon Sep 17 00:00:00 2001 From: Michael Lotz Date: Sat, 13 Sep 2008 00:28:29 +0000 Subject: [PATCH] CID 26: The status variable was shadowed inside the while loop causing the outer status to always be B_OK, resulting in an incomplete buffer instead of an error if the append failed. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27469 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/add-ons/kernel/network/protocols/tcp/BufferQueue.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/kernel/network/protocols/tcp/BufferQueue.cpp b/src/add-ons/kernel/network/protocols/tcp/BufferQueue.cpp index 779ede5e57..e1944c6cbc 100644 --- a/src/add-ons/kernel/network/protocols/tcp/BufferQueue.cpp +++ b/src/add-ons/kernel/network/protocols/tcp/BufferQueue.cpp @@ -323,7 +323,7 @@ BufferQueue::Get(size_t bytes, bool remove, net_buffer **_buffer) status_t status = B_OK; while (bytesLeft > 0 && (source = iterator.Next()) != NULL) { size_t size = min_c(source->size, bytesLeft); - status_t status = gBufferModule->append_cloned(buffer, source, 0, size); + status = gBufferModule->append_cloned(buffer, source, 0, size); if (status < B_OK) break;