From 4f77a907ba4dac8024f6d3d79dcd32c9d9625f6b Mon Sep 17 00:00:00 2001 From: Jaroslaw Pelczar Date: Wed, 28 Aug 2019 09:55:42 +0200 Subject: [PATCH] debuganalyzer: Fix catch of polymorphic object by value Signed-off-by: Jaroslaw Pelczar Change-Id: I1290a313905d3d940532c7c1626a631bf70afb29 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1762 Reviewed-by: waddlesplash --- src/apps/debuganalyzer/gui/AbstractWaitObjectsPage.h | 2 +- src/apps/debuganalyzer/gui/main_window/MainWindow.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/apps/debuganalyzer/gui/AbstractWaitObjectsPage.h b/src/apps/debuganalyzer/gui/AbstractWaitObjectsPage.h index 3b6ab1a7ae..7a55e04219 100644 --- a/src/apps/debuganalyzer/gui/AbstractWaitObjectsPage.h +++ b/src/apps/debuganalyzer/gui/AbstractWaitObjectsPage.h @@ -528,7 +528,7 @@ ABSTRACT_WAIT_OBJECTS_PAGE_CLASS::_UpdateTreeModel() try { fWaitObjectsTreeModel = new WaitObjectsTreeModel(fModel, fGroupByName); - } catch (std::bad_alloc) { + } catch (std::bad_alloc&) { // TODO: Report error! } fWaitObjectsTree->SetTreeTableModel(fWaitObjectsTreeModel); diff --git a/src/apps/debuganalyzer/gui/main_window/MainWindow.cpp b/src/apps/debuganalyzer/gui/main_window/MainWindow.cpp index 57b4bac047..767e7d9d32 100644 --- a/src/apps/debuganalyzer/gui/main_window/MainWindow.cpp +++ b/src/apps/debuganalyzer/gui/main_window/MainWindow.cpp @@ -177,7 +177,7 @@ MainWindow::OpenThreadWindow(Model::Thread* thread) // window doesn't exist yet -- create it try { window = new ThreadWindow(fSubWindowManager, fModel, thread); - } catch (std::bad_alloc) { + } catch (std::bad_alloc&) { // TODO: Report error! }