From 51599367a233071ed03e16db21b2b42568babd19 Mon Sep 17 00:00:00 2001
From: beveloper <beveloper@nowhere.fake>
Date: Sun, 15 Aug 2004 12:00:03 +0000
Subject: [PATCH] made error messages a little more informative

git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8572 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/kits/media/DefaultMediaTheme.cpp | 16 ++++++++--------
 src/kits/media/ParameterWeb.cpp      |  3 ++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/kits/media/DefaultMediaTheme.cpp b/src/kits/media/DefaultMediaTheme.cpp
index bed5523fa5..7ac85e2e43 100644
--- a/src/kits/media/DefaultMediaTheme.cpp
+++ b/src/kits/media/DefaultMediaTheme.cpp
@@ -532,7 +532,7 @@ ContinuousMessageFilter::ContinuousMessageFilter(BControl *control, BContinuousP
 	float value[fParameter.CountChannels()];
 	size_t size = sizeof(value);
 	if (parameter.GetValue((void *)&value, &size, NULL) < B_OK) {
-		ERROR("Could not get parameter value for %p\n", &parameter);
+		ERROR("ContinuousMessageFilter: Could not get value for continuous parameter %p (name '%s', node %d)\n", &parameter, parameter.Name(), parameter.Web()->Node().node);
 		return;
 	}
 
@@ -545,7 +545,7 @@ ContinuousMessageFilter::ContinuousMessageFilter(BControl *control, BContinuousP
 
 		slider->SetModificationMessage(new BMessage(kMsgParameterChanged));
 	} else
-		printf("unknown discrete parameter view\n");
+		ERROR("ContinuousMessageFilter: unknown continuous parameter view\n");
 }
 
 
@@ -575,10 +575,10 @@ ContinuousMessageFilter::Filter(BMessage *message, BHandler **target)
 			value[i] = (float)(slider->ValueFor(i) / 1000.0);
 	}
 
-	printf("update view %s, %ld channels\n", control->Name(), fParameter.CountChannels());
+	TRACE("ContinuousMessageFilter::Filter: update view %s, %ld channels\n", control->Name(), fParameter.CountChannels());
 
 	if (fParameter.SetValue((void *)value, sizeof(value), system_time()) < B_OK) {
-		ERROR("Could not set parameter value for %p\n", &fParameter);
+		ERROR("ContinuousMessageFilter::Filter: Could not set parameter value for %p\n", &fParameter);
 		return B_DISPATCH_MESSAGE;
 	}
 
@@ -601,7 +601,7 @@ DiscreteMessageFilter::DiscreteMessageFilter(BControl *control, BDiscreteParamet
 	size_t size = sizeof(int32);
 	int32 value;
 	if (parameter.GetValue((void *)&value, &size, NULL) < B_OK) {
-		ERROR("Could not get parameter value for %p\n", &parameter);
+		ERROR("DiscreteMessageFilter: Could not get value for discrete parameter %p (name '%s', node %d)\n", &parameter, parameter.Name(), parameter.Web()->Node().node);
 		return;
 	}
 
@@ -610,7 +610,7 @@ DiscreteMessageFilter::DiscreteMessageFilter(BControl *control, BDiscreteParamet
 	} else if (BOptionPopUp *popUp = dynamic_cast<BOptionPopUp *>(control)) {
 		popUp->SelectOptionFor(value);
 	} else
-		printf("unknown discrete parameter view\n");
+		ERROR("DiscreteMessageFilter: unknown discrete parameter view\n");
 }
 
 
@@ -638,10 +638,10 @@ DiscreteMessageFilter::Filter(BMessage *message, BHandler **target)
 		popUp->SelectedOption(NULL, &value);
 	}
 
-	printf("update view %s, value = %ld\n", control->Name(), value);
+	TRACE("DiscreteMessageFilter::Filter: update view %s, value = %ld\n", control->Name(), value);
 
 	if (fParameter.SetValue((void *)&value, sizeof(value), system_time()) < B_OK) {
-		ERROR("Could not set parameter value for %p\n", &fParameter);
+		ERROR("DiscreteMessageFilter::Filter: Could not set parameter value for %p\n", &fParameter);
 		return B_DISPATCH_MESSAGE;
 	}
 
diff --git a/src/kits/media/ParameterWeb.cpp b/src/kits/media/ParameterWeb.cpp
index 1a09604df7..1b2342fb81 100644
--- a/src/kits/media/ParameterWeb.cpp
+++ b/src/kits/media/ParameterWeb.cpp
@@ -1383,7 +1383,8 @@ BParameter::GetValue(void *buffer, size_t *_ioSize, bigtime_t *_when)
 		if (_when != NULL)
 			*_when = reply.last_change;
 	} else
-		ERROR("BParameter::GetValue querying node failed: %s\n", strerror(status));
+		ERROR("BParameter::GetValue parameter '%s' querying node %d, port %d failed: %s\n", 
+			mName, node.node, node.port, strerror(status));
 
 	if (area >= B_OK)
 		delete_area(area);