i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* Fixed bug #2727: symlinks usually "abuse" the data stream part of a

Browse Source 
bfs_inode to store the link path (up to a certain length). If this was long
  enough to clobber the data_stream::size field (which luckily was the last
  field of struct data_stream), Inode::Free() would mistakenly assume this to
  be a valid data stream to be freed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28311 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2008-10-24 10:36:43 +00:00
parent 0982317bea
commit 528b69d508
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/bfs/Inode.cpp
+6 -4
View File
@@ -2151,9 +2151,11 @@ Inode::Free(Transaction& transaction)
// Perhaps there should be an implementation of Inode::ShrinkStream() that // Perhaps there should be an implementation of Inode::ShrinkStream() that
// just frees the data_stream, but doesn't change the inode (since it is // just frees the data_stream, but doesn't change the inode (since it is
// freed anyway) - that would make an undelete command possible // freed anyway) - that would make an undelete command possible
status_t status = SetFileSize(transaction, 0); if (!IsSymLink() || (Flags() & INODE_LONG_SYMLINK) != 0) {
if (status < B_OK) status_t status = SetFileSize(transaction, 0);
return status; if (status < B_OK)
return status;
}
// Free all attributes, and remove their indices // Free all attributes, and remove their indices
{ {
@@ -2165,7 +2167,7 @@ Inode::Free(Transaction& transaction)
uint32 type; uint32 type;
size_t length; size_t length;
ino_t id; ino_t id;
while ((status = iterator.GetNext(name, &length, &type, &id)) == B_OK) { while (iterator.GetNext(name, &length, &type, &id) == B_OK) {
RemoveAttribute(transaction, name); RemoveAttribute(transaction, name);
} }
} }