BString: rewrite cleanup methods

This removes the use of the destructor in the move assignment operator, as it may rely on undefined behaviour from the compiler. Additionally, some duplicate logic to dereference and free a shared string has been unified under _ReleasePrivateData(). Change-Id: Ie9f51d598c734f83cd0fba49b651315c6e9c8aac Reviewed-on: https://review.haiku-os.org/c/haiku/+/4440 Reviewed-by: waddlesplash <[email protected]> Tested-by: Commit checker robot <[email protected]>
2021-09-10 05:34:06 +00:00
parent 6da19c9e40
commit 530f89aa6d
2 changed files with 15 additions and 21 deletions
@@ -423,6 +423,7 @@ private:
 			const int32& 	_ReferenceCount() const;
 			bool			_IsShareable() const;
 			void			_FreePrivateData();
+			void			_ReleasePrivateData();

 			char*			fPrivateData;
 };