i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network/protocols/unix: Recheck fShutdown{Read|Write} before socket notify.

Browse Source 
They may have changed, and we must not use the socket object if they
are set.

Related to #18535.
This commit is contained in:
Augustin Cavalier
2023-08-04 12:59:15 -04:00
parent 967ab75d8e
commit 5590a8194b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/network/protocols/unix/UnixDatagramEndpoint.cpp
+4 -2
View File
@@ -288,14 +288,16 @@ UnixDatagramEndpoint::Send(const iovec* vecs, size_t vecCount,
fifoLocker.Unlock(); fifoLocker.Unlock();
targetLocker.Lock(); targetLocker.Lock();
if (notifyRead) // We must recheck fShutdownRead after reacquiring the lock, as it may have changed.
if (notifyRead && !targetEndpoint->fShutdownRead)
gSocketModule->notify(targetEndpoint->socket, B_SELECT_READ, readable); gSocketModule->notify(targetEndpoint->socket, B_SELECT_READ, readable);
targetLocker.Unlock(); targetLocker.Unlock();
if (notifyWrite) { if (notifyWrite) {
endpointLocker.Lock(); endpointLocker.Lock();
gSocketModule->notify(socket, B_SELECT_WRITE, writable); if (!fShutdownWrite)
gSocketModule->notify(socket, B_SELECT_WRITE, writable);
} }
switch (result) { switch (result) {