i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a warning about the uninitialized use of variable team.

Browse Source 
Added a ToDo item because gcc is right and itemSize may be used uninitialized;
someone with a better understanding of this code should fix it.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8233 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2004-06-29 19:44:26 +00:00
parent 2410a823c6
commit 576416d2d7
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/app/Message.cpp
+8 -10
View File
@@ -715,6 +715,8 @@ status_t BMessage::Unflatten(BDataIO* stream)
} }
else else
{ {
// ToDo: gcc is right, itemSize is used uninitialized here!!
// Since I don't know how to fix it properly, I leave this warning in
// Have to account for 8-byte boundary padding // Have to account for 8-byte boundary padding
dataPtr += itemSize + (8 - (itemSize % 8)); dataPtr += itemSize + (8 - (itemSize % 8));
} }
@@ -1821,26 +1823,22 @@ status_t BMessage::send_message(port_id port, team_id port_owner, int32 token,
assert(cached_reply_port < sNumReplyPorts); assert(cached_reply_port < sNumReplyPorts);
reply_port = sReplyPorts[cached_reply_port]; reply_port = sReplyPorts[cached_reply_port];
} }
team_id team;
if (be_app) team_id team = B_BAD_TEAM_ID;
{ if (be_app != NULL)
team = be_app->Team(); team = be_app->Team();
} else {
else
{
port_info pi; port_info pi;
err = get_port_info(reply_port, &pi); err = get_port_info(reply_port, &pi);
if (err) if (err)
{
goto error; goto error;
}
team = pi.team; team = pi.team;
} }
err = set_port_owner(reply_port, port_owner); err = set_port_owner(reply_port, port_owner);
if (err) if (err)
{
goto error; goto error;
}
{ {
BMessenger messenger(team, reply_port, B_PREFERRED_TOKEN, false); BMessenger messenger(team, reply_port, B_PREFERRED_TOKEN, false);