From 58dbf89d718d7832ad177da1f972b4c50f5571b6 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 13 Jun 2020 09:18:44 +0900 Subject: [PATCH] Locale Kit: Fix PVS V773 Fix BTimeUnitFormat::Formatunction() was exited without releasing 'timeUnitAmount' pointer. Change-Id: I1d3cedd3ca376a7874ce5305b31194ae054e1a0c Reviewed-on: https://review.haiku-os.org/c/haiku/+/2911 Reviewed-by: waddlesplash --- src/kits/locale/TimeUnitFormat.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kits/locale/TimeUnitFormat.cpp b/src/kits/locale/TimeUnitFormat.cpp index c91b530058..a47dee7128 100644 --- a/src/kits/locale/TimeUnitFormat.cpp +++ b/src/kits/locale/TimeUnitFormat.cpp @@ -121,8 +121,10 @@ BTimeUnitFormat::Format(BString& buffer, const int32 value, = new TimeUnitAmount((double)value, skUnitMap[unit], icuStatus); if (timeUnitAmount == NULL) return B_NO_MEMORY; - if (!U_SUCCESS(icuStatus)) + if (!U_SUCCESS(icuStatus)) { + delete timeUnitAmount; return B_ERROR; + } Formattable formattable; formattable.adoptObject(timeUnitAmount);