i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

No longer draws any lines over the thumb area in B_BLOCK_THUMB mode.

Browse Source 
It's now completely flicker-free in that mode, all known drawing bugs are gone.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13358 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2005-06-29 23:08:57 +00:00
parent 9b030c1d2d
commit 597aa5f24d
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/Slider.cpp
+15 -2
View File
@@ -757,9 +757,10 @@ BSlider::DrawBar()
lowerFrame.top++; lowerFrame.top++;
lowerFrame.left++; lowerFrame.left++;
BRect upperFrame = lowerFrame; BRect upperFrame = lowerFrame;
BRect thumbFrame;
if (Style() == B_BLOCK_THUMB) { if (Style() == B_BLOCK_THUMB) {
BRect thumbFrame = ThumbFrame(); thumbFrame = ThumbFrame();
if (fOrientation == B_HORIZONTAL) { if (fOrientation == B_HORIZONTAL) {
lowerFrame.right = thumbFrame.left; lowerFrame.right = thumbFrame.left;
@@ -789,7 +790,16 @@ BSlider::DrawBar()
view->FillRect(lowerFrame); view->FillRect(lowerFrame);
} }
// ToDo: don't stroke the lines over the thumb if (Style() == B_BLOCK_THUMB) {
// We don't want to stroke the lines over the thumb
PushState();
BRegion region;
GetClippingRegion(&region);
region.Exclude(thumbFrame);
ConstrainClippingRegion(&region);
}
view->SetHighColor(darken1); view->SetHighColor(darken1);
view->StrokeLine(BPoint(frame.left, frame.top), view->StrokeLine(BPoint(frame.left, frame.top),
@@ -818,6 +828,9 @@ BSlider::DrawBar()
BPoint(frame.left, frame.top)); BPoint(frame.left, frame.top));
view->StrokeLine(BPoint(frame.left + 1.0f, frame.top), view->StrokeLine(BPoint(frame.left + 1.0f, frame.top),
BPoint(frame.right, frame.top)); BPoint(frame.right, frame.top));
if (Style() == B_BLOCK_THUMB)
PopState();
} }