From 5c5195ee7eef64a9b7b8dbb443a223e5272faf2d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= <superstippi@gmx.de>
Date: Sat, 20 Jun 2009 15:26:34 +0000
Subject: [PATCH] Fixed regression in SetViewCursor(). It wasn't possible
 anymore to switch back to the system default cursor. For that cursor token,
 the global cursor manager returns NULL.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31138 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/servers/app/ServerApp.cpp | 55 ++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 27 deletions(-)

diff --git a/src/servers/app/ServerApp.cpp b/src/servers/app/ServerApp.cpp
index 96424923e6..c3bf5e12fd 100644
--- a/src/servers/app/ServerApp.cpp
+++ b/src/servers/app/ServerApp.cpp
@@ -931,43 +931,44 @@ ServerApp::_DispatchMessage(int32 code, BPrivate::LinkReceiver& link)
 			if (fDesktop->GetCursorManager().Lock()) {
 				ServerCursor* cursor = fDesktop->GetCursorManager().FindCursor(
 					info.cursorToken);
-				// If we found a cursor, make sure it doesn't go away.
+				// If we found a cursor, make sure it doesn't go away. If we
+				// get a NULL cursor, it probably means we are supposed to use
+				// the system default cursor.
 				if (cursor != NULL)
 					cursor->Acquire();
 
 				fDesktop->GetCursorManager().Unlock();
 
-				if (cursor != NULL) {
-					// We need to acquire the write lock here, since we cannot
-					// afford that the window thread to which the view belongs
-					// is running and messing with that same view.
-					fDesktop->LockAllWindows();
+				// We need to acquire the write lock here, since we cannot
+				// afford that the window thread to which the view belongs
+				// is running and messing with that same view.
+				fDesktop->LockAllWindows();
 
-					// Find the corresponding view by the given token. It's ok
-					// if this view does not exist anymore, since it may have
-					// already be deleted in the window thread before this
-					// message got here.
-					View* view;
-					if (fViewTokens.GetToken(info.viewToken, B_HANDLER_TOKEN,
-						(void**)&view) == B_OK) {
-						// Set the cursor on the view.
-						view->SetCursor(cursor);
+				// Find the corresponding view by the given token. It's ok
+				// if this view does not exist anymore, since it may have
+				// already be deleted in the window thread before this
+				// message got here.
+				View* view;
+				if (fViewTokens.GetToken(info.viewToken, B_HANDLER_TOKEN,
+					(void**)&view) == B_OK) {
+					// Set the cursor on the view.
+					view->SetCursor(cursor);
 
-						// The cursor might need to be updated now.
-						Window* window = view->Window();
-						if (window != NULL && window->IsFocus()) {
-							if (fDesktop->ViewUnderMouse(window)
-								== view->Token()) {
-								SetCurrentCursor(cursor);
-							}
+					// The cursor might need to be updated now.
+					Window* window = view->Window();
+					if (window != NULL && window->IsFocus()) {
+						if (fDesktop->ViewUnderMouse(window)
+							== view->Token()) {
+							SetCurrentCursor(cursor);
 						}
 					}
-
-					fDesktop->UnlockAllWindows();
-
-					// Release the temporary reference.
-					cursor->Release();
 				}
+
+				fDesktop->UnlockAllWindows();
+
+				// Release the temporary reference.
+				if (cursor != NULL)
+					cursor->Release();
 			}
 
 			if (info.sync) {