From 5cf7633a392d6d15532fdea53ba719d4f92231fd Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Thu, 5 Dec 2024 16:59:06 -0500 Subject: [PATCH] Revert "kernel/vm: Remove an obsolete comment." This reverts commit 1db0961121bdb8145fe368fdca0205ddef354729. It turns out the comment is not obsolete; what it refers to isn't PAE systems but true 32-bit ones. I'm not sure we should use 64-bit cache offsets even there, but that's a decision for another time. --- headers/private/kernel/vm/vm_types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/headers/private/kernel/vm/vm_types.h b/headers/private/kernel/vm/vm_types.h index f37f191855..138f8a144b 100644 --- a/headers/private/kernel/vm/vm_types.h +++ b/headers/private/kernel/vm/vm_types.h @@ -123,6 +123,8 @@ private: public: page_num_t cache_offset; // in page size units + // TODO: Only 32 bit on 32 bit platforms! + // Introduce a new 64 bit type page_off_t! SplayTreeLink cache_link; vm_page* cache_next;