i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kernel/vm: Add assertion for a TODO comment in mark_page_range_in_use.

Browse Source 
It should be OK to call this during kernel startup without using
reservations, since it's mostly used for fixed memory ranges
specified by the bootloader.

Also turn a later dprintf into a panic.
This commit is contained in:
Augustin Cavalier
2024-10-10 11:39:20 -04:00
parent 1db0961121
commit 5e451463d0
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/vm/vm_page.cpp
+6 -4
View File
@@ -1783,9 +1783,11 @@ mark_page_range_in_use(page_num_t startPage, page_num_t length, bool wired)
case PAGE_STATE_FREE: case PAGE_STATE_FREE:
case PAGE_STATE_CLEAR: case PAGE_STATE_CLEAR:
{ {
// TODO: This violates the page reservation policy, since we remove pages from // This violates the page reservation policy, since we remove pages
// the free/clear queues without having reserved them before. This should happen // from the free/clear queues without having reserved them before.
// in the early boot process only, though. // This should happen in the early boot process only, though.
ASSERT(gKernelStartup);
DEBUG_PAGE_ACCESS_START(page); DEBUG_PAGE_ACCESS_START(page);
VMPageQueue& queue = page->State() == PAGE_STATE_FREE VMPageQueue& queue = page->State() == PAGE_STATE_FREE
? sFreePageQueue : sClearPageQueue; ? sFreePageQueue : sClearPageQueue;
@@ -1805,7 +1807,7 @@ mark_page_range_in_use(page_num_t startPage, page_num_t length, bool wired)
case PAGE_STATE_CACHED: case PAGE_STATE_CACHED:
default: default:
// uh // uh
dprintf("mark_page_range_in_use: page %#" B_PRIxPHYSADDR panic("mark_page_range_in_use: page %#" B_PRIxPHYSADDR
" in non-free state %d!\n", startPage + i, page->State()); " in non-free state %d!\n", startPage + i, page->State());
break; break;
} }