i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove clamping in new BSplitLayout methods.

Browse Source 
Since clamping the index for these methods could lead to confusing side effects, we'll just avoid the clamping, and let things segfault when the programmer goes out of bounds.

Closes #7902
This commit is contained in:
Alex Wilson
2011-12-22 14:16:44 -07:00
parent e0821f1d73
commit 61084e53b5
1 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/SplitLayout.cpp
-20
View File
@@ -465,11 +465,6 @@ BSplitLayout::SetItemWeight(BLayoutItem* item, float weight)
bool bool
BSplitLayout::IsCollapsible(int32 index) const BSplitLayout::IsCollapsible(int32 index) const
{ {
if (index < 0)
index = 0;
if (index > CountItems())
index = CountItems() - 1;
return _ItemLayoutInfo(ItemAt(index))->isCollapsible; return _ItemLayoutInfo(ItemAt(index))->isCollapsible;
} }
@@ -491,11 +486,6 @@ BSplitLayout::SetCollapsible(int32 index, bool collapsible)
void void
BSplitLayout::SetCollapsible(int32 first, int32 last, bool collapsible) BSplitLayout::SetCollapsible(int32 first, int32 last, bool collapsible)
{ {
if (first < 0)
first = 0;
if (last < 0 || last > CountItems())
last = CountItems() - 1;
for (int32 i = first; i <= last; i++) for (int32 i = first; i <= last; i++)
_ItemLayoutInfo(ItemAt(i))->isCollapsible = collapsible; _ItemLayoutInfo(ItemAt(i))->isCollapsible = collapsible;
} }
@@ -504,11 +494,6 @@ BSplitLayout::SetCollapsible(int32 first, int32 last, bool collapsible)
bool bool
BSplitLayout::IsItemCollapsed(int32 index) const BSplitLayout::IsItemCollapsed(int32 index) const
{ {
if (index < 0)
index = 0;
if (index > CountItems())
index = CountItems() - 1;
return _ItemLayoutInfo(ItemAt(index))->isVisible; return _ItemLayoutInfo(ItemAt(index))->isVisible;
} }
@@ -516,11 +501,6 @@ BSplitLayout::IsItemCollapsed(int32 index) const
void void
BSplitLayout::SetItemCollapsed(int32 index, bool collapsed) BSplitLayout::SetItemCollapsed(int32 index, bool collapsed)
{ {
if (index < 0)
index = 0;
if (index > CountItems())
index = CountItems() - 1;
ItemAt(index)->SetVisible(collapsed); ItemAt(index)->SetVisible(collapsed);
InvalidateLayout(true); InvalidateLayout(true);