From 61b433252a46c552c07b1516d4c750063fcf0d77 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Wed, 30 Oct 2019 20:22:23 +0900 Subject: [PATCH] Netfs: Fix memory error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In Reader::Read(), memory is allocated to '*buffer' at line 40, but freed with 'buffer' at line 45. Pointed by Clang Static Analyzer. Change-Id: I18e49791da639a6bc2041e944a39ceb73a2e5055 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1931 Reviewed-by: Axel Dörfler --- .../kernel/file_systems/netfs/shared/RequestUnflattener.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/kernel/file_systems/netfs/shared/RequestUnflattener.cpp b/src/add-ons/kernel/file_systems/netfs/shared/RequestUnflattener.cpp index 41c99416c5..e682d68bfe 100644 --- a/src/add-ons/kernel/file_systems/netfs/shared/RequestUnflattener.cpp +++ b/src/add-ons/kernel/file_systems/netfs/shared/RequestUnflattener.cpp @@ -42,7 +42,7 @@ Reader::Read(int32 size, void** buffer, bool* mustFree) return B_NO_MEMORY; status_t error = Read(*buffer, size); if (error != B_OK) { - free(buffer); + free(*buffer); return error; } return error;