i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* We need to delay the checksum computation after the reply is complete.

Browse Source 
* Also, we need to set the buffer's protocol.
* Now we actually send correct ICMP messages.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37710 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2010-07-23 10:04:40 +00:00
parent d98980a446
commit 6404b00512
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/network/protocols/icmp/icmp.cpp
+6 -3
View File
@@ -463,8 +463,6 @@ icmp_error_reply(net_protocol* protocol, net_buffer* buffer, uint32 code,
icmpHeader->gateway = errorData ? *((uint32*)errorData) : 0; icmpHeader->gateway = errorData ? *((uint32*)errorData) : 0;
icmpHeader->checksum = 0; icmpHeader->checksum = 0;
icmpHeader.Sync(); icmpHeader.Sync();
*ICMPChecksumField(reply)
= gBufferModule->checksum(reply, 0, reply->size, true);
// Append IP header + 8 byte of the original datagram // Append IP header + 8 byte of the original datagram
status_t status = gBufferModule->append_restored_header(reply, buffer, 0, status_t status = gBufferModule->append_restored_header(reply, buffer, 0,
@@ -474,7 +472,12 @@ icmp_error_reply(net_protocol* protocol, net_buffer* buffer, uint32 code,
if (domain == NULL) if (domain == NULL)
return B_ERROR; return B_ERROR;
TRACE(" send ICMP message to %s\n", AddressString( *ICMPChecksumField(reply)
= gBufferModule->checksum(reply, 0, reply->size, true);
reply->protocol = IPPROTO_ICMP;
TRACE(" send ICMP message %p to %s\n", reply, AddressString(
domain->address_module, reply->destination, true).Data()); domain->address_module, reply->destination, true).Data());
status = domain->module->send_data(NULL, reply); status = domain->module->send_data(NULL, reply);