i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CID 890. dest was leaked on error. To me it seems that src is leaked too,

Browse Source 
and there's even a comment that says we are leaking memory.
Coverity doesn't complain, though, so I wonder if I'm wrong. Please someone
have a second look.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38241 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini
2010-08-18 16:25:31 +00:00
parent 5026e5cca4
commit 64bd6d9651
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/mail/MailAttachment.cpp
+3 -1
View File
@@ -369,8 +369,10 @@ status_t BSimpleMailAttachment::RenderToRFC822(BPositionIO *render_to) {
return B_NO_MEMORY; return B_NO_MEMORY;
destSize = encode (_encoding, dest, src, read, false /* headerMode */); destSize = encode (_encoding, dest, src, read, false /* headerMode */);
if (destSize < B_OK) if (destSize < B_OK) {
free(dest);
return destSize; return destSize;
}
if (destSize > 0) if (destSize > 0)
read = render_to->Write(dest,destSize); read = render_to->Write(dest,destSize);
free (src); free (src);