Touchpad: Obligatory style fixes

This commit is contained in:
John Scipione
2013-11-21 23:52:26 -05:00
parent 5632a8f0de
commit 65423794de
2 changed files with 18 additions and 17 deletions
+15 -14
View File
@@ -104,12 +104,13 @@ TouchpadView::MouseUp(BPoint point)
|| GetBottomScrollRatio() > kSoftScrollLimit) { || GetBottomScrollRatio() > kSoftScrollLimit) {
BAlert* alert = new BAlert(B_TRANSLATE("Please confirm"), BAlert* alert = new BAlert(B_TRANSLATE("Please confirm"),
B_TRANSLATE("The new scroll area is very large and may impede " B_TRANSLATE("The new scroll area is very large and may impede "
"normal mouse operation. Do you really want to change it?"), "normal mouse operation. Do you really want to change it?"),
B_TRANSLATE("OK"), B_TRANSLATE("Cancel"), B_TRANSLATE("OK"), B_TRANSLATE("Cancel"),
NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT); NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT);
alert->SetShortcut(1, B_ESCAPE); alert->SetShortcut(1, B_ESCAPE);
result = alert->Go(); result = alert->Go();
} }
if (result == 0) { if (result == 0) {
BMessage msg(SCROLL_AREA_CHANGED); BMessage msg(SCROLL_AREA_CHANGED);
Invoke(&msg); Invoke(&msg);
@@ -126,9 +127,9 @@ TouchpadView::MouseUp(BPoint point)
void void
TouchpadView::AttachedToWindow() TouchpadView::AttachedToWindow()
{ {
if (!fOffScreenView) { if (!fOffScreenView)
fOffScreenView = new BView(Bounds(), "", B_FOLLOW_ALL, B_WILL_DRAW); fOffScreenView = new BView(Bounds(), "", B_FOLLOW_ALL, B_WILL_DRAW);
}
if (!fOffScreenBitmap) { if (!fOffScreenBitmap) {
fOffScreenBitmap = new BBitmap(Bounds(), B_CMAP8, true, false); fOffScreenBitmap = new BBitmap(Bounds(), B_CMAP8, true, false);
@@ -188,11 +189,7 @@ TouchpadView::MouseMoved(BPoint point, uint32 transit, const BMessage* message)
void void
TouchpadView::DrawSliders() TouchpadView::DrawSliders()
{ {
BView* view; BView* view = fOffScreenView != NULL ? fOffScreenView : this;
if (fOffScreenView != NULL)
view = fOffScreenView;
else
view = this;
if (!LockLooper()) if (!LockLooper())
return; return;
@@ -283,16 +280,18 @@ TouchpadPrefView::~TouchpadPrefView()
void void
TouchpadPrefView::MessageReceived(BMessage* msg) TouchpadPrefView::MessageReceived(BMessage* message)
{ {
touchpad_settings& settings = fTouchpadPref.Settings(); touchpad_settings& settings = fTouchpadPref.Settings();
switch (msg->what) {
switch (message->what) {
case SCROLL_AREA_CHANGED: case SCROLL_AREA_CHANGED:
settings.scroll_rightrange = fTouchpadView->GetRightScrollRatio(); settings.scroll_rightrange = fTouchpadView->GetRightScrollRatio();
settings.scroll_bottomrange = fTouchpadView->GetBottomScrollRatio(); settings.scroll_bottomrange = fTouchpadView->GetBottomScrollRatio();
fRevertButton->SetEnabled(true); fRevertButton->SetEnabled(true);
fTouchpadPref.UpdateSettings(); fTouchpadPref.UpdateSettings();
break; break;
case SCROLL_CONTROL_CHANGED: case SCROLL_CONTROL_CHANGED:
settings.scroll_twofinger = fTwoFingerBox->Value() == B_CONTROL_ON; settings.scroll_twofinger = fTwoFingerBox->Value() == B_CONTROL_ON;
settings.scroll_twofinger_horizontal settings.scroll_twofinger_horizontal
@@ -304,27 +303,30 @@ TouchpadPrefView::MessageReceived(BMessage* msg)
fTwoFingerHorizontalBox->SetEnabled(settings.scroll_twofinger); fTwoFingerHorizontalBox->SetEnabled(settings.scroll_twofinger);
fTouchpadPref.UpdateSettings(); fTouchpadPref.UpdateSettings();
break; break;
case TAP_CONTROL_CHANGED: case TAP_CONTROL_CHANGED:
settings.tapgesture_sensibility = fTapSlider->Value(); settings.tapgesture_sensibility = fTapSlider->Value();
fRevertButton->SetEnabled(true); fRevertButton->SetEnabled(true);
fTouchpadPref.UpdateSettings(); fTouchpadPref.UpdateSettings();
break; break;
case DEFAULT_SETTINGS: case DEFAULT_SETTINGS:
fTouchpadPref.Defaults(); fTouchpadPref.Defaults();
fRevertButton->SetEnabled(true); fRevertButton->SetEnabled(true);
fTouchpadPref.UpdateSettings(); fTouchpadPref.UpdateSettings();
SetValues(&settings); SetValues(&settings);
break; break;
case REVERT_SETTINGS: case REVERT_SETTINGS:
fTouchpadPref.Revert(); fTouchpadPref.Revert();
fTouchpadPref.UpdateSettings(); fTouchpadPref.UpdateSettings();
fRevertButton->SetEnabled(false); fRevertButton->SetEnabled(false);
SetValues(&settings); SetValues(&settings);
break; break;
default:
BView::MessageReceived(msg);
}
default:
BView::MessageReceived(message);
}
} }
@@ -481,4 +483,3 @@ TouchpadPrefView::SetValues(touchpad_settings* settings)
fScrollAccelSlider->SetValue(settings->scroll_acceleration); fScrollAccelSlider->SetValue(settings->scroll_acceleration);
fTapSlider->SetValue(settings->tapgesture_sensibility); fTapSlider->SetValue(settings->tapgesture_sensibility);
} }
+3 -3
View File
@@ -84,9 +84,9 @@ class TouchpadPrefView : public BGroupView {
public: public:
TouchpadPrefView(); TouchpadPrefView();
virtual ~TouchpadPrefView(); virtual ~TouchpadPrefView();
virtual void MessageReceived(BMessage* msg); virtual void MessageReceived(BMessage* message);
virtual void AttachedToWindow(); virtual void AttachedToWindow();
virtual void DetachedFromWindow(); virtual void DetachedFromWindow();
void SetupView(); void SetupView();
void SetValues(touchpad_settings *settings); void SetValues(touchpad_settings *settings);