i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MidiPlayer: Fix crash when dropping a midi file

Browse Source 
Window must be locked or MidiRunThread crashes with a segment violation.

Change-Id: I9d5d0fa477475a9b5ba877aea3d6583690aacb2b
Reviewed-on: https://review.haiku-os.org/c/1080
Reviewed-by: Barrett17 <[email protected]>
This commit is contained in:
John Scipione
2019-02-25 11:57:46 +00:00
committed by Barrett17
parent 5b88998b2d
commit 65c0d507d3
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/midiplayer/MidiPlayerWindow.cpp
+8 -7
View File
@@ -427,17 +427,18 @@ MidiPlayerWindow::_StopHook(int32 arg)
void void
MidiPlayerWindow::StopHook() MidiPlayerWindow::StopHook()
{ {
Lock(); if (Lock()) {
// we may be called from the synth's thread // we may be called from the synth's thread
fIsPlaying = false; fIsPlaying = false;
fScopeView->SetPlaying(false); fScopeView->SetPlaying(false);
fScopeView->Invalidate(); fScopeView->Invalidate();
fPlayButton->SetEnabled(true); fPlayButton->SetEnabled(true);
fPlayButton->SetLabel(B_TRANSLATE("Play")); fPlayButton->SetLabel(B_TRANSLATE("Play"));
Unlock(); Unlock();
}
} }