From 66bce8233aa664cfb6ac31fb234a0cf4950e585e Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Fri, 16 May 2014 09:17:15 +0200 Subject: [PATCH] CID 1210936: use after free. --- src/apps/terminal/TermView.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/apps/terminal/TermView.cpp b/src/apps/terminal/TermView.cpp index 8bd3616f8c..f06ab5f6db 100644 --- a/src/apps/terminal/TermView.cpp +++ b/src/apps/terminal/TermView.cpp @@ -2601,10 +2601,10 @@ TermView::_AddHighlight(Highlight* highlight) void TermView::_RemoveHighlight(Highlight* highlight) { - fHighlights.RemoveItem(highlight); - if (!highlight->IsEmpty()) _InvalidateTextRange(highlight->Start(), highlight->End()); + + fHighlights.RemoveItem(highlight); }