From 690bccd46abf943e5e269d27863bf531ad0d13a5 Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Wed, 30 Oct 2013 01:51:23 +0100 Subject: [PATCH] BPackageInfo::StringBuilder: Fix writing non-string lists Even a list with only one element needs to be enclosed in {...}. --- src/kits/package/PackageInfoStringBuilder.h | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/kits/package/PackageInfoStringBuilder.h b/src/kits/package/PackageInfoStringBuilder.h index db3b988cc7..4e4c33d323 100644 --- a/src/kits/package/PackageInfoStringBuilder.h +++ b/src/kits/package/PackageInfoStringBuilder.h @@ -130,21 +130,16 @@ private: // encapsulating the stringification via templates seems to result in // an Internal Compiler Error with gcc 2. + _Write("{\n", 2); + int32 count = value.CountItems(); - if (count == 1) { - _WriteListElement(value.ItemAt(0)); - } else { - _Write("{\n", 2); - - int32 count = value.CountItems(); - for (int32 i = 0; i < count; i++) { - _Write('\t'); - _WriteListElement(value.ItemAt(i)); - _Write('\n'); - } - - _Write('}'); + for (int32 i = 0; i < count; i++) { + _Write('\t'); + _WriteListElement(value.ItemAt(i)); + _Write('\n'); } + + _Write('}'); } template