i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Debugger: Move line-info version check up and print a warning.

Browse Source 
This way it will be clear why there is no line-info.
This commit is contained in:
Augustin Cavalier
2023-08-25 16:57:57 -04:00
parent 15969ccf84
commit 692e2e45bb
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/debugger/dwarf/DwarfFile.cpp
+6 -3
View File
@@ -1779,6 +1779,12 @@ DwarfFile::_ParseLineInfo(CompilationUnit* unit)
// version (uhalf) // version (uhalf)
uint16 version = dataReader.Read<uint16>(0); uint16 version = dataReader.Read<uint16>(0);
if (version != 2 && version != 3) {
WARNING("DwarfFile::_ParseLineInfo(\"%s\"): unsupported "
"version %d\n", fName, version);
return B_UNSUPPORTED;
}
// header_length (4/8) // header_length (4/8)
uint64 headerLength = dwarf64 uint64 headerLength = dwarf64
? dataReader.Read<uint64>(0) : (uint64)dataReader.Read<uint32>(0); ? dataReader.Read<uint64>(0) : (uint64)dataReader.Read<uint32>(0);
@@ -1809,9 +1815,6 @@ DwarfFile::_ParseLineInfo(CompilationUnit* unit)
if (dataReader.HasOverflow()) if (dataReader.HasOverflow())
return B_BAD_DATA; return B_BAD_DATA;
if (version != 2 && version != 3)
return B_UNSUPPORTED;
TRACE_LINES(" unitLength: %" B_PRIu64 "\n", unitLength); TRACE_LINES(" unitLength: %" B_PRIu64 "\n", unitLength);
TRACE_LINES(" version: %u\n", version); TRACE_LINES(" version: %u\n", version);
TRACE_LINES(" headerLength: %" B_PRIu64 "\n", headerLength); TRACE_LINES(" headerLength: %" B_PRIu64 "\n", headerLength);