From 69cd1bde897390198bf416286dc550bdd1d019dc Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Thu, 4 Mar 2021 06:29:15 +0900 Subject: [PATCH] keymap: fix value stored to 'flags' is never read Fix 'flags' was not used in In KeyboardLayoutView::_DrawKeyButton(). Pointed by Clang Static Analyzer. Change-Id: Ic3b2da856ee410e908eaaf0c5c4b5b3753928c00 Reviewed-on: https://review.haiku-os.org/c/haiku/+/4079 Tested-by: Commit checker robot Reviewed-by: Adrien Destugues --- src/preferences/keymap/KeyboardLayoutView.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/preferences/keymap/KeyboardLayoutView.cpp b/src/preferences/keymap/KeyboardLayoutView.cpp index f8e568a794..c9890eaa79 100644 --- a/src/preferences/keymap/KeyboardLayoutView.cpp +++ b/src/preferences/keymap/KeyboardLayoutView.cpp @@ -700,12 +700,11 @@ KeyboardLayoutView::_DrawKeyButton(BView* view, BRect& rect, BRect updateRect, rgb_color base, rgb_color background, bool pressed) { uint32 flags = pressed ? BControlLook::B_ACTIVATED : 0; - flags |= BControlLook::B_FLAT; be_control_look->DrawButtonFrame(view, rect, updateRect, 4.0f, base, - background, pressed ? BControlLook::B_ACTIVATED : 0); + background, flags); be_control_look->DrawButtonBackground(view, rect, updateRect, 4.0f, - base, pressed ? BControlLook::B_ACTIVATED : 0); + base, flags); }