From 69d16976497be026b2058532dae0153de0442882 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Tue, 16 Jun 2020 06:01:11 +0900 Subject: [PATCH] userlandfs/server/fuse: Fix PVS V773 Fix FUSEVolume::OpenAttr() was exited without releasing the 'cookie' pointer. Change-Id: I8bf08268c77e1c9704227b1d4c7c94ddcc8b09a3 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2947 Reviewed-by: waddlesplash --- .../kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp b/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp index a358c74a04..87538a9fd7 100644 --- a/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp +++ b/src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp @@ -2211,8 +2211,10 @@ FUSEVolume::OpenAttr(void* _node, const char* name, int openMode, int bytesRead = fuse_fs_getxattr(fFS, path, name, cookie->Buffer(), attrSize); - if (bytesRead < 0) + if (bytesRead < 0) { + delete cookie; return bytesRead; + } *_cookie = cookie;