i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Debugger: Fix jobs trying to re-add dependencies.

Browse Source 
Linked lists are used to manage these, so if we re-add
jobs we'll corrupt the linked lists and cause crashes.

Fixes #19864 and possibly others.
This commit is contained in:
Augustin Cavalier
2026-01-06 18:01:24 -05:00
parent 327215ce38
commit 6a1ad86129
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/debugger/util/Worker.cpp
+7
View File
@@ -415,6 +415,13 @@ Worker::WaitForJob(Job* waitingJob, const JobKey& key)
if (job == NULL) if (job == NULL)
return JOB_DEPENDENCY_NOT_FOUND; return JOB_DEPENDENCY_NOT_FOUND;
if (waitingJob->Dependency() == job)
return waitingJob->WaitStatus();
if (job == waitingJob)
debugger("Jobs can't depend on themselves");
if (waitingJob->Dependency() != NULL)
debugger("Job already has a dependency");
waitingJob->SetWaitStatus(JOB_DEPENDENCY_ACTIVE); waitingJob->SetWaitStatus(JOB_DEPENDENCY_ACTIVE);
waitingJob->SetDependency(job); waitingJob->SetDependency(job);
job->DependentJobs().Add(waitingJob); job->DependentJobs().Add(waitingJob);