i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added TODO comments about some race conditions in the code because of unlocking

Browse Source 
the desktop.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17139 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2006-04-16 13:18:35 +00:00
parent b2536cb5d6
commit 6aa4743b51
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/app/ServerWindow.cpp
+3
View File
@@ -607,6 +607,7 @@ fDesktop->LockSingleWindow();
WindowLayer *behindOf; WindowLayer *behindOf;
if ((behindOf = fDesktop->FindWindowLayerByClientToken(token, teamID)) != NULL) { if ((behindOf = fDesktop->FindWindowLayerByClientToken(token, teamID)) != NULL) {
fDesktop->UnlockSingleWindow(); fDesktop->UnlockSingleWindow();
// TODO: there is a big race condition when we unlock here (window could be gone by now)!
fDesktop->SendWindowBehind(fWindowLayer, behindOf); fDesktop->SendWindowBehind(fWindowLayer, behindOf);
fDesktop->LockSingleWindow(); fDesktop->LockSingleWindow();
status = B_OK; status = B_OK;
@@ -673,6 +674,7 @@ fDesktop->LockSingleWindow();
status = B_BAD_VALUE; status = B_BAD_VALUE;
} else { } else {
fDesktop->UnlockSingleWindow(); fDesktop->UnlockSingleWindow();
// TODO: there is a big race condition when we unlock here (window could be gone by now)!
status = fDesktop->AddWindowToSubset(fWindowLayer, windowLayer) status = fDesktop->AddWindowToSubset(fWindowLayer, windowLayer)
? B_OK : B_NO_MEMORY; ? B_OK : B_NO_MEMORY;
fDesktop->LockSingleWindow(); fDesktop->LockSingleWindow();
@@ -694,6 +696,7 @@ fDesktop->LockSingleWindow();
token, App()->ClientTeam()); token, App()->ClientTeam());
if (windowLayer != NULL) { if (windowLayer != NULL) {
fDesktop->UnlockSingleWindow(); fDesktop->UnlockSingleWindow();
// TODO: there is a big race condition when we unlock here (window could be gone by now)!
fDesktop->RemoveWindowFromSubset(fWindowLayer, windowLayer); fDesktop->RemoveWindowFromSubset(fWindowLayer, windowLayer);
fDesktop->LockSingleWindow(); fDesktop->LockSingleWindow();
status = B_OK; status = B_OK;