i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libnetapi: Fix use after free

Browse Source 
Fix 'fImpl' is used after delete in BNetBuffer::operator=
(GetImpl() returns fImpl), when it is used with self assignment.
Pointed out by Clang Static Analyzer.

Change-Id: Ic80a4ce73879062581b9241f84a4340919d281b9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3393
Reviewed-by: Jérôme Duval <[email protected]>
This commit is contained in:
Murai Takashi
2020-11-15 20:05:58 +00:00
committed by Adrien Destugues
parent a756a8ad1b
commit 6c016dc54a
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/network/libnetapi/NetBuffer.cpp
+2 -1
View File
@@ -66,12 +66,13 @@ BNetBuffer::BNetBuffer(BMessage* archive) :
BNetBuffer& BNetBuffer&
BNetBuffer::operator=(const BNetBuffer& buffer) BNetBuffer::operator=(const BNetBuffer& buffer)
{ {
if (&buffer != this) {
delete fImpl; delete fImpl;
fImpl = new (std::nothrow) DynamicBuffer(*buffer.GetImpl()); fImpl = new (std::nothrow) DynamicBuffer(*buffer.GetImpl());
if (fImpl != NULL) if (fImpl != NULL)
fInit = fImpl->InitCheck(); fInit = fImpl->InitCheck();
}
return *this; return *this;
} }