netfs: Enable Werror for netfs.

* Fix warnings by adding casts and intialization of an on-stack allocated array.
* Activate Werror for netfs.
* Part of ticket #9460

Change-Id: I91c603232e5d96a3ceed60fcc0be45b64df6b7e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10340
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>

build/jam/ArchitectureRules

@@ -732,7 +732,7 @@ rule ArchitectureSetupWarnings architecture
 	EnableWerror src add-ons kernel file_systems googlefs ;
 	EnableWerror src add-ons kernel file_systems iso9660 ;
 	EnableWerror src add-ons kernel file_systems layers ;
-#	EnableWerror src add-ons kernel file_systems netfs ;
+	EnableWerror src add-ons kernel file_systems netfs ;
 	EnableWerror src add-ons kernel file_systems nfs ;
 	EnableWerror src add-ons kernel file_systems nfs4 ;
 #	EnableWerror src add-ons kernel file_systems ntfs ;

headers/private/userlandfs/shared/Vector.h

@@ -286,7 +286,7 @@ void
 _VECTOR_CLASS_NAME::_MoveItems(Value* items, int32 offset, int32 count)
 {
 	if (count > 0 && offset != 0)
-		memmove(items + offset, items, count * sizeof(Value));
+		memmove((void*)(items + offset), items, count * sizeof(Value));
 }
 
 // Insert
@@ -722,7 +722,7 @@ _VECTOR_CLASS_NAME::_Resize(size_t count)
 	newSize = ((newSize - 1) / fChunkSize + 1) * fChunkSize;
 	// resize if necessary
 	if ((size_t)newSize != fCapacity) {
-		Value* newItems = (Value*)realloc(fItems, newSize * sizeof(Value));
+		Value* newItems = (Value*)realloc((void*)fItems, newSize * sizeof(Value));
 		if (newItems) {
 			fItems = newItems;
 			fCapacity = newSize;

src/add-ons/kernel/file_systems/netfs/headers/shared/RequestMemberArray.h

@@ -103,7 +103,7 @@ private:
 				capacity = 2 * fCapacity;
 
 			Member* elements
-				= (Member*)realloc(fElements, capacity * sizeof(Member));
+				= (Member*)realloc((void*)fElements, capacity * sizeof(Member));
 			if (!elements)
 				return B_NO_MEMORY;
 

src/add-ons/kernel/file_systems/netfs/shared/RequestFlattener.cpp

@@ -26,7 +26,7 @@ Writer::Pad(int32 size)
 	if (size > 8)
 		return B_BAD_VALUE;
 
-	char buffer[8];
+	char buffer[8] = {0};
 	return Write(buffer, size);
 }