i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kernel/user_debugger: Add missing permissions checks.

Browse Source 
Part of #14961.
This commit is contained in:
Augustin Cavalier
2019-07-04 16:54:50 -04:00
parent a90e9ba7b9
commit 6f0aa00c6b
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/debug/user_debugger.cpp
+12
View File
@@ -2834,6 +2834,10 @@ _user_disable_debugger(int state)
status_t status_t
_user_install_default_debugger(port_id debuggerPort) _user_install_default_debugger(port_id debuggerPort)
{ {
// Do not allow non-root processes to install a default debugger.
if (geteuid() != 0)
return B_PERMISSION_DENIED;
// if supplied, check whether the port is a valid port // if supplied, check whether the port is a valid port
if (debuggerPort >= 0) { if (debuggerPort >= 0) {
port_info portInfo; port_info portInfo;
@@ -2855,6 +2859,14 @@ _user_install_default_debugger(port_id debuggerPort)
port_id port_id
_user_install_team_debugger(team_id teamID, port_id debuggerPort) _user_install_team_debugger(team_id teamID, port_id debuggerPort)
{ {
if (geteuid() != 0) {
Team* team = team_get_team_struct(teamID);
if (team == NULL)
return B_BAD_VALUE;
if (team->effective_uid != geteuid())
return B_PERMISSION_DENIED;
}
return install_team_debugger(teamID, debuggerPort, -1, false, false); return install_team_debugger(teamID, debuggerPort, -1, false, false);
} }