From 706fc8e3c62556b20415b2cfdb68361944176300 Mon Sep 17 00:00:00 2001 From: John Scipione Date: Sun, 3 May 2026 18:07:06 -0400 Subject: [PATCH] Tracker: Fix drop onto file assume parent directory regression. Also fix a minor TODO regarding dropping file onto root dir. Regression from hrev59656, fixes #20069. Change-Id: I153539cb714b9a5872eca16da3aa4a8de25c0f64 Reviewed-on: https://review.haiku-os.org/c/haiku/+/10890 Reviewed-by: John Scipione Tested-by: Commit checker robot Haiku-Format: Haiku-format Bot --- src/kits/tracker/PoseView.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/kits/tracker/PoseView.cpp b/src/kits/tracker/PoseView.cpp index b6ce8708ee..796367afa0 100644 --- a/src/kits/tracker/PoseView.cpp +++ b/src/kits/tracker/PoseView.cpp @@ -4898,8 +4898,6 @@ BPoseView::HandleDropCommon(BMessage* message, Model* targetModel, BPose* target if (!wasHandled && poseView != NULL) { BPoint where = message->GetPoint("click_pt", B_ORIGIN); - // TODO: removed check for root here need to do that, possibly at a - // different level poseView->MoveSelectionTo(targetModel, dropPoint, srcWindow, where, moveMode); } @@ -5234,6 +5232,14 @@ BPoseView::MoveSelectionTo(Model* model, BPoint dropPoint, BContainerWindow* src ASSERT(model != NULL); + // use this directory unless we were passed a directory + if (!(model->IsDirectory() || model->IsVirtualDirectory())) + model = TargetModel(); + + // don't allow dropping files onto root + if (model->IsRoot()) + return; + // make sure this window is a legal drop target if (srcWindow != window && !model->IsDropTarget()) return;