From 7131246873bb76348fd0190427795983e3a12e9b Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Thu, 23 Nov 2017 17:53:06 +0100 Subject: [PATCH] BNetworkAddress: Close socket in ResolveForDestination. It was closed on all the failure cases but not on the success one. Found by Coverity. --- src/kits/network/libnetapi/NetworkAddress.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/kits/network/libnetapi/NetworkAddress.cpp b/src/kits/network/libnetapi/NetworkAddress.cpp index 2bfbcd10df..7eaf5a166c 100644 --- a/src/kits/network/libnetapi/NetworkAddress.cpp +++ b/src/kits/network/libnetapi/NetworkAddress.cpp @@ -963,6 +963,7 @@ BNetworkAddress::ResolveForDestination(const BNetworkAddress& destination) memcpy(&fAddress, route->source, sizeof(sockaddr_storage)); SetPort(port); + close(socket); return B_OK; } @@ -1293,7 +1294,7 @@ BNetworkAddress::_ParseLinkAddress(const char* address) address += 3; } - + fHostName = address; SetToLinkLevel(linkAddress, length);