i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* As pointed out by Rene the buffer size in snprintf

Browse Source 
includes the 0-terminator.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39995 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Michael Pfeiffer
2010-12-28 21:24:58 +00:00
parent fdee209b00
commit 737e45854e
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/preferences/printers/JobListView.cpp
+1 -1
View File
@@ -216,7 +216,7 @@ JobItem::Update()
off_t size; off_t size;
if (node.GetSize(&size) == B_OK) { if (node.GetSize(&size) == B_OK) {
char buffer[80]; char buffer[80];
snprintf(buffer, sizeof(buffer) - 1, B_TRANSLATE("%.2f KB"), snprintf(buffer, sizeof(buffer), B_TRANSLATE("%.2f KB"),
size / 1024.0); size / 1024.0);
fSize = buffer; fSize = buffer;
} }
src/servers/print/ConfigWindow.cpp
+6 -6
View File
@@ -524,23 +524,23 @@ ConfigWindow::UpdateUI()
== B_OK && copies > 1) { == B_OK && copies > 1) {
if (printRange) { if (printRange) {
job = B_TRANSLATE("Page %1 to %2, %3 copies"); job = B_TRANSLATE("Page %1 to %2, %3 copies");
snprintf(number, sizeof(number) - 1, "%d", (int)first); snprintf(number, sizeof(number), "%d", (int)first);
job.ReplaceFirst("%1", number); job.ReplaceFirst("%1", number);
snprintf(number, sizeof(number) - 1, "%d", (int)last); snprintf(number, sizeof(number), "%d", (int)last);
job.ReplaceFirst("%2", number); job.ReplaceFirst("%2", number);
snprintf(number, sizeof(number) - 1, "%d", (int)copies); snprintf(number, sizeof(number), "%d", (int)copies);
job.ReplaceFirst("%3", number); job.ReplaceFirst("%3", number);
} else { } else {
job = B_TRANSLATE("All pages, %1 copies"); job = B_TRANSLATE("All pages, %1 copies");
snprintf(number, sizeof(number) - 1, "%d", (int)copies); snprintf(number, sizeof(number), "%d", (int)copies);
job.ReplaceFirst("%1", number); job.ReplaceFirst("%1", number);
} }
} else { } else {
if (printRange) { if (printRange) {
job = B_TRANSLATE("Page %1 to %2"); job = B_TRANSLATE("Page %1 to %2");
snprintf(number, sizeof(number) - 1, "%d", (int)first); snprintf(number, sizeof(number), "%d", (int)first);
job.ReplaceFirst("%1", number); job.ReplaceFirst("%1", number);
snprintf(number, sizeof(number) - 1, "%d", (int)last); snprintf(number, sizeof(number), "%d", (int)last);
job.ReplaceFirst("%2", number); job.ReplaceFirst("%2", number);
} else } else
job = B_TRANSLATE("All pages"); job = B_TRANSLATE("All pages");