kernel/timer: Code cleanup.

* Remove some unnecessary casts.
 * Clean up linked-list logic in add_event_to_list(). As previous->next
   will just be the same as "next", we can use that directly and thus
   remove some code duplication.

No functional change intended.
This commit is contained in:
Augustin Cavalier
2024-08-15 12:38:51 -04:00
parent 3fb85af36c
commit 74238e36f2
+5 -7
View File
@@ -74,17 +74,15 @@ add_event_to_list(timer* event, timer** list)
timer* next; timer* next;
timer* previous = NULL; timer* previous = NULL;
// stick it in the event list for (next = *list; next != NULL; previous = next, next = previous->next) {
for (next = *list; next != NULL; previous = next, next = (timer*)next->next) {
if ((bigtime_t)next->schedule_time >= (bigtime_t)event->schedule_time) if ((bigtime_t)next->schedule_time >= (bigtime_t)event->schedule_time)
break; break;
} }
if (previous != NULL) { event->next = next;
event->next = previous->next; if (previous != NULL)
previous->next = event; previous->next = event;
} else { else
event->next = next;
*list = event; *list = event;
} }
} }
@@ -259,7 +257,7 @@ timer_interrupt()
// this event needs to happen // this event needs to happen
int mode = event->flags; int mode = event->flags;
cpuData.events = (timer*)event->next; cpuData.events = event->next;
cpuData.current_event = event; cpuData.current_event = event;
atomic_set(&cpuData.current_event_in_progress, 1); atomic_set(&cpuData.current_event_in_progress, 1);