From 79d1ca0fa900e6394c3cab29d18d8b7bbf548040 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Tue, 16 Jul 2019 20:40:02 +0200 Subject: [PATCH] PVS V564: use of bitwise operators on booleans Change-Id: I0a0cd7ddba0abaef27700f1ba05bf99bb8c7a400 Reviewed-on: https://review.haiku-os.org/c/1607 Reviewed-by: waddlesplash --- src/add-ons/accelerants/common/i2c.c | 2 +- .../kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp | 4 ++-- src/system/libroot/posix/stdlib/strtod.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/add-ons/accelerants/common/i2c.c b/src/add-ons/accelerants/common/i2c.c index c828a9614e..e6515674a5 100644 --- a/src/add-ons/accelerants/common/i2c.c +++ b/src/add-ons/accelerants/common/i2c.c @@ -273,7 +273,7 @@ send_slave_address(const i2c_bus *bus, int slaveAddress, bool isWrite) status_t status; TRACE("%s: 0x%X\n", __func__, slaveAddress); - status = send_byte(bus, (slaveAddress & 0xfe) | !isWrite, true); + status = send_byte(bus, (slaveAddress & 0xfe) | (isWrite ? 0 : 1), true); if (status != B_OK) return status; diff --git a/src/add-ons/kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp b/src/add-ons/kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp index af67fa33f9..ad23564db6 100644 --- a/src/add-ons/kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp +++ b/src/add-ons/kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp @@ -290,11 +290,11 @@ TabletProtocolHandler::_ReadReport(void *buffer, uint32 *cookie) bool inRange = true; if (fRange != NULL && fRange->Extract() == B_OK && fRange->Valid()) - inRange = fRange->Data() & 1 != 0; + inRange = ((fRange->Data() & 1) != 0); bool eraser = false; if (fEraser != NULL && fEraser->Extract() == B_OK && fEraser->Valid()) - eraser = (fEraser->Data() & 1) != 0; + eraser = ((fEraser->Data() & 1) != 0); fReport.DoneProcessing(); TRACE("got tablet report\n"); diff --git a/src/system/libroot/posix/stdlib/strtod.c b/src/system/libroot/posix/stdlib/strtod.c index 7eadb13c4e..b578cefcd0 100644 --- a/src/system/libroot/posix/stdlib/strtod.c +++ b/src/system/libroot/posix/stdlib/strtod.c @@ -542,7 +542,7 @@ lo0bits(ULong *y) if (!(x & 1)) { k++; x >>= 1; - if (!x & 1) + if (!(x & 1)) return 32; } *y = x;