From 7abf1b6fba46db78b32cc4a9267a8b7ee019edaa Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 21 Sep 2019 15:56:54 +0900 Subject: [PATCH] media-add-ons/mixer: Fix 'new[]' array freed with 'delete' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fMixBufferChannelTypes is allocated by new[] in _ApplyOutputFormat(), but freed by delete. Pointed out by LGTM. Change-Id: I07b85801e0103094c5751306ea2c50ca9354ddb9 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1877 Reviewed-by: Axel Dörfler --- src/add-ons/media/media-add-ons/mixer/MixerCore.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/add-ons/media/media-add-ons/mixer/MixerCore.cpp b/src/add-ons/media/media-add-ons/mixer/MixerCore.cpp index 9d82ac0cba..cb832f693d 100644 --- a/src/add-ons/media/media-add-ons/mixer/MixerCore.cpp +++ b/src/add-ons/media/media-add-ons/mixer/MixerCore.cpp @@ -112,7 +112,7 @@ MixerCore::~MixerCore() delete[] fResampler; } - delete fMixBufferChannelTypes; + delete[] fMixBufferChannelTypes; } @@ -429,7 +429,7 @@ MixerCore::_ApplyOutputFormat() if (fMixBuffer != NULL) rtm_free(fMixBuffer); - delete fMixBufferChannelTypes; + delete[] fMixBufferChannelTypes; fMixBufferFrameRate = (int32)(0.5 + format.frame_rate); fMixBufferFrameCount = frames_per_buffer(format);