From 7bac04e684cbe14ea4c7ed8180071a40fc948a96 Mon Sep 17 00:00:00 2001 From: Leorize Date: Thu, 16 Jul 2020 01:47:57 -0500 Subject: [PATCH] HttpRequest: Don't wait for socket to be readable The socket is a blocking one, which means Read() will block unless data is available, thus WaitForReadable() is useless in this context. Testing also shows a 2x performance increase from removing this call due to poll() performance being botched when KDEBUG_LEVEL >= 2. Change-Id: I3170f865e961112b420c1548726bb6fd38e94cb2 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3078 Reviewed-by: waddlesplash --- src/kits/network/libnetapi/HttpRequest.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/kits/network/libnetapi/HttpRequest.cpp b/src/kits/network/libnetapi/HttpRequest.cpp index a7ff40f932..1490e2efdf 100644 --- a/src/kits/network/libnetapi/HttpRequest.cpp +++ b/src/kits/network/libnetapi/HttpRequest.cpp @@ -584,7 +584,6 @@ BHttpRequest::_MakeRequest() while (!fQuit && !(receiveEnd && parseEnd)) { if ((!receiveEnd) && (fInputBuffer.Size() == previousBufferSize)) { - fSocket->WaitForReadable(); BStackOrHeapArray chunk(kHttpBufferSize); bytesRead = fSocket->Read(chunk, kHttpBufferSize);