From 7ddb9624b23605ee64a176e73d222a2b74f424fa Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 21 Sep 2019 16:04:11 +0900 Subject: [PATCH] Terminal: Fix mismatching malloc/delete MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fAlternateScreen is allocated by malloc() in BasicTerminalBuffer::_AllocateLines(), but freed by delete. Pointed out by LGTM. Change-Id: I526ecd7e570caf7d5ed90c715bbbfaf40e7e4be6 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1882 Reviewed-by: Axel Dörfler --- src/apps/terminal/TerminalBuffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/terminal/TerminalBuffer.cpp b/src/apps/terminal/TerminalBuffer.cpp index 2637285f00..e3fd5fb731 100644 --- a/src/apps/terminal/TerminalBuffer.cpp +++ b/src/apps/terminal/TerminalBuffer.cpp @@ -39,7 +39,7 @@ TerminalBuffer::TerminalBuffer() TerminalBuffer::~TerminalBuffer() { - delete fAlternateScreen; + free(fAlternateScreen); delete fAlternateHistory; delete[] fColorsPalette; }