From 7de035619bf4e660f3f2243b343de4dffc7ab79b Mon Sep 17 00:00:00 2001 From: Rene Gollent Date: Tue, 17 Sep 2013 18:08:21 +0200 Subject: [PATCH] Debugger: Fix off by one error in report generator. - The disassembly dump would consequently stop at the instruction prior to the actual crash culprit, and also erroneously mark it as such. --- src/apps/debugger/controllers/DebugReportGenerator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/apps/debugger/controllers/DebugReportGenerator.cpp b/src/apps/debugger/controllers/DebugReportGenerator.cpp index 60cdba9026..bf45375753 100644 --- a/src/apps/debugger/controllers/DebugReportGenerator.cpp +++ b/src/apps/debugger/controllers/DebugReportGenerator.cpp @@ -566,9 +566,9 @@ DebugReportGenerator::_DumpFunctionDisassembly(BString& _output, SourceLocation location = statement->StartSourceLocation(); _output << "\t\t\tDisassembly:\n"; - for (int32 i = 0; i < location.Line(); i++) { + for (int32 i = 0; i <= location.Line(); i++) { _output << "\t\t\t\t" << code->LineAt(i); - if (i == location.Line() - 1) + if (i == location.Line()) _output << " <--"; _output << "\n"; }