From 7ffd2c9e59e2d31b31c9f8ca5f3cf887e65ca116 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Duval?= <jerome.duval@gmail.com>
Date: Fri, 26 Jul 2024 19:01:28 +0200
Subject: [PATCH] kernel: LegacyDevice: SetHooks() needs a non-null
 fDeviceModule
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

fix gcc analyzer warning

Change-Id: Ic2aaeebb516f680ba40c343c01d5be1a9232d46d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7907
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
---
 src/system/kernel/device_manager/legacy_drivers.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/system/kernel/device_manager/legacy_drivers.cpp b/src/system/kernel/device_manager/legacy_drivers.cpp
index fc74d40db7..a53c595548 100644
--- a/src/system/kernel/device_manager/legacy_drivers.cpp
+++ b/src/system/kernel/device_manager/legacy_drivers.cpp
@@ -1251,13 +1251,14 @@ LegacyDevice::LegacyDevice(legacy_driver* driver, const char* path,
 	fRemovedFromParent(false)
 {
 	fDeviceModule = (device_module_info*)malloc(sizeof(device_module_info));
-	if (fDeviceModule != NULL)
+	if (fDeviceModule != NULL) {
 		memset(fDeviceModule, 0, sizeof(device_module_info));
+		SetHooks(hooks);
+	}
 
 	fDeviceData = this;
 	fPath = strdup(path);
 
-	SetHooks(hooks);
 }