From 81d0a0e0a76f3d7188b5ea318c2f1540e1b210e9 Mon Sep 17 00:00:00 2001 From: David Murphy Date: Tue, 11 Sep 2018 16:51:27 -0400 Subject: [PATCH] BColumnListView: Always update the reference rect in ::FindVisibleRect... ...if the row is present in the list, but continue to return false if the row is not currently visible on the screen. Part of #11675. Cherry-picked from https://review.haiku-os.org/442. --- src/kits/interface/ColumnListView.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/kits/interface/ColumnListView.cpp b/src/kits/interface/ColumnListView.cpp index 2c0ed08e2a..0c0dc8627b 100644 --- a/src/kits/interface/ColumnListView.cpp +++ b/src/kits/interface/ColumnListView.cpp @@ -4561,13 +4561,11 @@ OutlineView::FindVisibleRect(BRow* row, BRect* _rect) float line = 0.0; for (RecursiveOutlineIterator iterator(&fRows); iterator.CurrentRow(); iterator.GoToNext()) { - if (line > fVisibleRect.bottom) - break; if (iterator.CurrentRow() == row) { _rect->Set(fVisibleRect.left, line, fVisibleRect.right, line + row->Height()); - return true; + return line <= fVisibleRect.bottom; } line += iterator.CurrentRow()->Height() + 1;