i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hda: prevent buffer overrun for associations array.

Browse Source
This commit is contained in:
Jessica Hamilton
2017-06-29 13:56:54 -07:00
parent a5fb17bc65
commit 8253046311
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/drivers/audio/hda/hda_codec.cpp
+4
View File
@@ -640,6 +640,10 @@ hda_widget_get_associations(hda_audio_group* audioGroup)
uint32 index = 0; uint32 index = 0;
for (uint32 i = 0; i < MAX_ASSOCIATIONS; i++) { for (uint32 i = 0; i < MAX_ASSOCIATIONS; i++) {
for (uint32 j = 0; j < audioGroup->widget_count; j++) { for (uint32 j = 0; j < audioGroup->widget_count; j++) {
if (index >= MAX_ASSOCIATIONS) {
TRACE("too many associations, bailing!\n");
return B_ERROR;
}
hda_widget& widget = audioGroup->widgets[j]; hda_widget& widget = audioGroup->widgets[j];
if (widget.type != WT_PIN_COMPLEX) if (widget.type != WT_PIN_COMPLEX)