From 8361c0f11a24c782a7ab21e8f26a5f0236ec6a4c Mon Sep 17 00:00:00 2001 From: Michael Lotz Date: Thu, 23 Apr 2015 23:13:20 +0200 Subject: [PATCH] ActivityMonitor: Fix leak of message when saving settings. Adding a message to a message does not transfer ownership. --- src/apps/activitymonitor/ActivityWindow.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/apps/activitymonitor/ActivityWindow.cpp b/src/apps/activitymonitor/ActivityWindow.cpp index 449c7752c8..62279b94f2 100644 --- a/src/apps/activitymonitor/ActivityWindow.cpp +++ b/src/apps/activitymonitor/ActivityWindow.cpp @@ -335,14 +335,12 @@ ActivityWindow::_SaveSettings() if (view == NULL) continue; - BMessage* viewState = new BMessage; - status = view->SaveState(*viewState); + BMessage viewState; + status = view->SaveState(viewState); if (status == B_OK) - status = settings.AddMessage("activity view", viewState); - if (status != B_OK) { - delete viewState; + status = settings.AddMessage("activity view", &viewState); + if (status != B_OK) break; - } } if (status == B_OK)